cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5681) Refactor IESCS in Snitches
Date Thu, 20 Jun 2013 22:59:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689803#comment-13689803
] 

Jason Brown edited comment on CASSANDRA-5681 at 6/20/13 10:58 PM:
------------------------------------------------------------------

Attached v1 patch extracts the IESCS work in Ec2MRS and GPFS into a new helper class, ReconnectableSnitchHelper
(which implements IESCS). I choose to create a new 'sidekick/helper' class rather than create
a new parent class as Ec2MRS already derives from Ec2Snitch, and it wouldn't make sense to
have Ec2Snitch derive from the new 'reconnecting' snitch as it doesn't need the reconnect
functionality.

Note: when applying to trunk, I will also refactor YamlFileNTS to use ReconnectableSnitchHelper
(as YamlFileNTS didn't exist in 1.2).

Note, 2: I'm open to renaming ReconnectableSnitchHelper to something more interesting (I'm
not thrilled with the 'Helper' suffix).
                
      was (Author: jasobrown):
    Attached v1 patch extracts the IESCS work in Ec2MRS and GPFS into a new helper class,
ReconnectableSnitchHelper (which implements IESCS). I choose to create a new 'sidekick/helper'
class rather than create a new parent class as Ec2MRS already derives from Ec2Snitch, and
it wouldn't make sense to have Ec2Snitch derive from the new 'reconnecting' snitch as it doesn't
need the reconnect functionality.

Note: when applying to trunk, will also refactor YamlFileNTS (as it didn't exist in 1.2).
                  
> Refactor IESCS in Snitches
> --------------------------
>
>                 Key: CASSANDRA-5681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.5
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>              Labels: snitch
>             Fix For: 1.2.6, 2.0 beta 1
>
>         Attachments: 5681-v1.diff
>
>
> Reduce/refactor duplicated IESCS implementations in Ec2MRS, GPFS, and YPNTS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message