cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Nistor (JIRA)" <>
Subject [jira] [Created] (CASSANDRA-5662) Wasted work in StorageService.initClient()
Date Wed, 19 Jun 2013 14:33:19 GMT
Adrian Nistor created CASSANDRA-5662:

             Summary: Wasted work in StorageService.initClient()
                 Key: CASSANDRA-5662
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 1.2.5
         Environment: any
            Reporter: Adrian Nistor
         Attachments: patch.diff

The problem appears in version 1.2.5 and in revision 26018be2..  I
attached a one-line patch that fixes it.

In method "StorageService.initClient", the loop over
"Gossiper.instance.getLiveMembers()" should break immediately after
"isUp" is set to "true".  All the iterations after "isUp" is set to
"true" do not perform any useful work, at best they just set "isUp"
again to "true".

Method "getCompactedRow" in class "ParallelCompactionIterable.Reducer"
has a similar loop (over "rows"), and this loop breaks immediately
after "inMemory" is set to "false", just like in the proposed patch.
Other methods (e.g., "GroupByPrefix.count",
"SecondaryIndex.buildIndexAsync") also have similar loops with similar
breaks, just like in the proposed patch.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message