cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5638) Improve StorageProxy tracing
Date Tue, 18 Jun 2013 13:29:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686699#comment-13686699
] 

Sylvain Lebresne commented on CASSANDRA-5638:
---------------------------------------------

lgtm, +1.

Nit: for consistency sake, we could start with a caps in
{noformat}
not hinting {} which has been down {}ms
{noformat}
Also, could be more user friendly to include the time after which we start not hinting.
                
> Improve StorageProxy tracing
> ----------------------------
>
>                 Key: CASSANDRA-5638
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5638
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.6
>
>         Attachments: 5638.txt
>
>
> Storage proxy includes some logger.trace methods that should be Tracing.trace, and more
logger.trace that aren't useful.
> Also QueryProcessor is not consistent about logging what it is executing and should include
ConsistencyLevel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message