cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5623) Cleanup interruption handling
Date Wed, 12 Jun 2013 14:03:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681239#comment-13681239
] 

Dave Brosius commented on CASSANDRA-5623:
-----------------------------------------

thanks for the clarification.

my concern is that how do i, in a code review, determine if this doesn't introduce infinite
loops, that were once broken out of by the IE. Also, fail fast tends to have safer/easier
to recover from behavior.

This patch might be fine, I'm just not sure how to prove it to myself.


                
> Cleanup interruption handling
> -----------------------------
>
>                 Key: CASSANDRA-5623
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5623
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Mikhail Mazursky
>            Assignee: Mikhail Mazursky
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: trunk-5623.txt
>
>
> There are a lot of catch-wrap-throw pattern occurances in code with InterruptedException.
I cleaned up some of them but not all - in some places I don't know enough about code to decide
if it's correct thing to do.
> Important: I also fixed possibility of wrong behaviour in case of spurious wakeup in
AsyncOneResponse.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message