cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbros...@apache.org
Subject git commit: passing an empty string to StringBuilder ctor is silly
Date Fri, 21 Jun 2013 23:43:50 GMT
Updated Branches:
  refs/heads/trunk c06e0b577 -> 5c5fdd40e


passing an empty string to StringBuilder ctor is silly


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5c5fdd40
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5c5fdd40
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5c5fdd40

Branch: refs/heads/trunk
Commit: 5c5fdd40ebac875ee0b4f9de1a7d1eea3b3788b9
Parents: c06e0b5
Author: Dave Brosius <dbrosius@apache.org>
Authored: Fri Jun 21 19:42:49 2013 -0400
Committer: Dave Brosius <dbrosius@apache.org>
Committed: Fri Jun 21 19:42:49 2013 -0400

----------------------------------------------------------------------
 src/java/org/apache/cassandra/net/MessageIn.java  | 2 +-
 src/java/org/apache/cassandra/net/MessageOut.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/5c5fdd40/src/java/org/apache/cassandra/net/MessageIn.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/MessageIn.java b/src/java/org/apache/cassandra/net/MessageIn.java
index b9d94b5..e0efefe 100644
--- a/src/java/org/apache/cassandra/net/MessageIn.java
+++ b/src/java/org/apache/cassandra/net/MessageIn.java
@@ -112,7 +112,7 @@ public class MessageIn<T>
 
     public String toString()
     {
-        StringBuilder sbuf = new StringBuilder("");
+        StringBuilder sbuf = new StringBuilder();
         sbuf.append("FROM:").append(from).append(" TYPE:").append(getMessageType()).append("
VERB:").append(verb);
         return sbuf.toString();
     }

http://git-wip-us.apache.org/repos/asf/cassandra/blob/5c5fdd40/src/java/org/apache/cassandra/net/MessageOut.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java b/src/java/org/apache/cassandra/net/MessageOut.java
index da9eda4..e10fcee 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -95,7 +95,7 @@ public class MessageOut<T>
 
     public String toString()
     {
-        StringBuilder sbuf = new StringBuilder("");
+        StringBuilder sbuf = new StringBuilder();
         sbuf.append("TYPE:").append(getStage()).append(" VERB:").append(verb);
         return sbuf.toString();
     }


Mime
View raw message