cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5577) Avoid unnecessary second pass on name-based queries
Date Fri, 17 May 2013 14:29:15 GMT


Sylvain Lebresne commented on CASSANDRA-5577:

The patch lgtm, though going a bit further I think we can always dispense ourselves of the
collateOnDiskAtom call. Because returning gcable tombstones during read should never be a
problem since we'll skip any tombstone before returning to the client.

Nit: might be worst adding as a comment than skipping collateOnDiskAtom is only ok because
we have a NamesQueryFilter, so we don't inadvertently copy the idea when a slice filter is

> Avoid unnecessary second pass on name-based queries
> ---------------------------------------------------
>                 Key: CASSANDRA-5577
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 2.0
>         Attachments: 5577.txt

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message