cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5537) Reduce Empty Map allocations in Directory.SSTableLister
Date Mon, 06 May 2013 12:46:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649703#comment-13649703
] 

Jonathan Ellis commented on CASSANDRA-5537:
-------------------------------------------

It's basically only used on startup, right?  I think I'm okay with slightly clearer code at
the expense of unneeded allocation in that case.
                
> Reduce Empty Map allocations in Directory.SSTableLister
> -------------------------------------------------------
>
>                 Key: CASSANDRA-5537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5537
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 2.0
>
>         Attachments: 5537.txt
>
>
> SSTableLister allocates HashMaps consistently that are very often not used.
> See output: http://pastebin.com/Ky4hUn5X
> Format is
> Type Date SourceLine CollectionSize NumBuckets NumBucketsUsed
> The snapshot is taken after the size of the collection hasn't changed for 5 seconds.
> Postpone creation of hashmap until you need it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message