cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5528) CLUSTERING ORDER BY support for cqlsh's DESCRIBE
Date Wed, 01 May 2013 16:16:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646677#comment-13646677
] 

Tyler Hobbs edited comment on CASSANDRA-5528 at 5/1/13 4:15 PM:
----------------------------------------------------------------

v2 patch makes the suggested simplifications and omits the CLUSTERING ORDER clause if there
aren't any DESC items.
                
      was (Author: thobbs):
    v2 patch makes the suggested simplifications and omits the CLUSTERING ORDER clause if
there aren't any DESC items.

{quote}
also, I don't fully understand why

{code}
if layout.compact_storage and not issubclass(layout.comparator, CompositeType)
{code}

is not just

{code}
if not issubclass(layout.comparator, CompositeType)
{code}
{quote}

I think this was needed for some 1.1 cases where a composite comparator wasn't used, but I
presume we don't care about that for a 1.2 change to cqlsh, is that correct?
                  
> CLUSTERING ORDER BY support for cqlsh's DESCRIBE
> ------------------------------------------------
>
>                 Key: CASSANDRA-5528
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5528
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>            Priority: Minor
>         Attachments: 5528-clustering-order-v1.txt, 5528-clustering-order-v2.txt, cql3_test_cases
>
>
> cqlsh currently does not output any sort of {{CLUSTERING ORDER BY}} options with {{DESCRIBE}}
and, furthermore, {{DESC}} orderings will result in bad column type definitions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message