cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5348) Remove on-heap row cache
Date Wed, 22 May 2013 20:48:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664507#comment-13664507
] 

Jason Brown commented on CASSANDRA-5348:
----------------------------------------

code lgtm, but tests couldn't compile

{code}    [javac] /usr/local/src/cassandra/test/unit/org/apache/cassandra/db/CollationControllerTest.java:73:
error: constructor CollationController in class CollationController cannot be applied to given
types;
    [javac]         CollationController controller = new CollationController(store, false,
filter, Integer.MIN_VALUE);
    [javac]                                          ^
    [javac]   required: ColumnFamilyStore,QueryFilter,int
    [javac]   found: ColumnFamilyStore,boolean,QueryFilter,int
    [javac]   reason: actual and formal argument lists differ in length
    [javac] /usr/local/src/cassandra/test/unit/org/apache/cassandra/db/CollationControllerTest.java:81:
error: constructor CollationController in class CollationController cannot be applied to given
types;
    [javac]         controller = new CollationController(store, false, filter, Integer.MIN_VALUE);
    [javac]                      ^
    [javac]   required: ColumnFamilyStore,QueryFilter,int
    [javac]   found: ColumnFamilyStore,boolean,QueryFilter,int
    [javac]   reason: actual and formal argument lists differ in length
{code}

Once I removed the boolean 'false' argument to the method, it compiled. Running tests now.
                
> Remove on-heap row cache
> ------------------------
>
>                 Key: CASSANDRA-5348
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5348
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 2.0
>
>         Attachments: 5348.txt
>
>
> The row (partition) cache easily does more harm than good.  People expect it to act like
a query cache but it is very different than that, especially for the wide partitions that
are so common in Cassandra data models.
> Making it off-heap by default only helped a little; we still have to deserialize the
partition to the heap to query it.
> Ultimately we can add a better cache based on the ideas in CASSANDRA-1956 or CASSANDRA-2864,
but even if we don't get to that until 2.1, removing the old row cache for 2.0 is a good idea.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message