cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Zarutin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5322) Make dtest logging more granular
Date Fri, 17 May 2013 09:11:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660504#comment-13660504
] 

Alex Zarutin commented on CASSANDRA-5322:
-----------------------------------------

>From Sylvain Lebresne:

The idea of making the changes to ccm doesn't seem crazy to me. It already allow to change
the global log level, so adding the possibility to change it only for a class or set of classes
(which is what #5322 wants if I'm not mistaken) would feel natural, and is probably useful
even outside the dtests.

Now on the details on how to do it, I'd prefer modifying the existing set_log_level method/command
rather than adding a new one. Typically, I could see adding a new optional argument to set_log_level,
say a map of a class name to it's log level, and then we'd set that up in __update_log4j (in
node.py) the same way we do it for the global log level.

This would be slightly less general that "importing" an external log4j file, but imo that's
enough for what we need and is simpler to use in practice. It's also more consistent for ccm.

--
Sylvain
                
> Make dtest logging more granular 
> ---------------------------------
>
>                 Key: CASSANDRA-5322
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5322
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Ryan McGuire
>            Assignee: Alex Zarutin
>
> From Brandon: We need a way (might need to go in ccm, I haven't looked) to just set one
class to DEBUG or TRACE, like we'd do in conf/log4-server.properties but with an env var preferably,
so I can control it via buildbot, since it's better at reproducing some issues than I am sometimes,
but I don't want to run the full hammer debug all the time. Also, a way to set Tester.allow_log_errors
to false via an env var, since sometimes there's an error there that takes a while to fix
but is cosmetic, and in the meantime I want to catch new failures so we don't fall behind.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message