Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14105FA6C for ; Mon, 22 Apr 2013 18:15:18 +0000 (UTC) Received: (qmail 59582 invoked by uid 500); 22 Apr 2013 18:15:16 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 59472 invoked by uid 500); 22 Apr 2013 18:15:16 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 59380 invoked by uid 99); 22 Apr 2013 18:15:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Apr 2013 18:15:16 +0000 Date: Mon, 22 Apr 2013 18:15:16 +0000 (UTC) From: "Oleksandr Petrov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5504) Eternal iteration when using newer hadoop version due to next() call and empty key value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638254#comment-13638254 ] Oleksandr Petrov commented on CASSANDRA-5504: --------------------------------------------- Hm... That's quite weird. Maybe there's something different with Thrift. I've seen people having trouble because of the message size, too, though. There're two settings, one for framed and one non-framed thrift. > Eternal iteration when using newer hadoop version due to next() call and empty key value > ---------------------------------------------------------------------------------------- > > Key: CASSANDRA-5504 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5504 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Affects Versions: 1.2.3 > Reporter: Oleksandr Petrov > Priority: Critical > Attachments: patch2.diff, patch.diff > > > Currently, when using newer hadoop versions, due to the call to > next(ByteBuffer key, SortedMap value) > within ColumnFamilyRecordReader, because `key.clear();` is called, key is emptied. That causes the StaticRowIterator and WideRowIterator to glitch, namely, when Iterables.getLast(rows).key is called, key is already empty. This will cause Hadoop to request the same range again and again all the time. > Please see the attached patch/diff, it simply adds lastRowKey (ByteBuffer) and saves it for the next iteration along with all the rows, this allows query for the next range to be fully correct. > This patch is branched from 1.2.3 version. > Tested against Cassandra 1.2.3, with Hadoop 1.0.3, 1.0.4 and 0.20.2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira