Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 7 Apr 2013 03:57:15 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12641212.1365279546446.122998.1365307035799@arcas>
In-Reply-To: <JIRA.12641212.1365279546446@arcas>
References: <JIRA.12641212.1365279546446@arcas>
Subject: [jira] [Commented] (CASSANDRA-5434) 2.0 CommitLogReplayer doesn't
 read checksum correctly for old commit logs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624626#comment-13624626 ] 

Jonathan Ellis commented on CASSANDRA-5434:
-------------------------------------------

More generally I don't think I'm really a fan of breaking out linear logic into a separate, non-re-used anyway. :)
                
> 2.0 CommitLogReplayer doesn't read checksum correctly for old commit logs
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5434
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5434
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: 5434.txt
>
>
> use the CommitLogDescriptor.getMessagingVersion() to determine how to read the checksum.
> added tests, as well. some refactors to make tests easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira