Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 18 Apr 2013 18:20:14 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12639405.1364407188732.187625.1366309214481@arcas>
In-Reply-To: <JIRA.12639405.1364407188732@arcas>
References: <JIRA.12639405.1364407188732@arcas>
Subject: [jira] [Commented] (CASSANDRA-5393) Add an Ack/Retry for merkle
 tree sending
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635468#comment-13635468 ] 

Jonathan Ellis commented on CASSANDRA-5393:
-------------------------------------------

Ship it!
                
> Add an Ack/Retry for merkle tree sending
> ----------------------------------------
>
>                 Key: CASSANDRA-5393
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5393
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.10, 1.2.4, 2.0
>            Reporter: Jeremiah Jordan
>            Assignee: Jason Brown
>             Fix For: 1.1.11, 1.2.5, 2.0
>
>         Attachments: 5393.patch, 5393-v2.patch, 5393-v3.patch, 5393-v4.txt
>
>
> Can we add an Ack/Retry around passing merle tree's around in repair?  If the following fails, the repair hangs for ever on the coordinating node.
> https://github.com/apache/cassandra/blob/cassandra-1.1.10/src/java/org/apache/cassandra/service/AntiEntropyService.java#L242
> {noformat}
>             Message message = TreeResponseVerbHandler.makeVerb(local, validator);
>             if (!validator.request.endpoint.equals(FBUtilities.getBroadcastAddress()))
>                 logger.info(String.format("[repair #%s] Sending completed merkle tree to %s for %s", validator.request.sessionid, validator.request.endpoint, validator.request.cf));
>             ms.sendOneWay(message, validator.request.endpoint);
> {noformat}
> If the message asking for merkle tree's gets lost, coordinating node hangs for ever as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira