Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 8 Apr 2013 21:42:16 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12623301.1355182647130.130362.1365457336546@arcas>
In-Reply-To: <JIRA.12623301.1355182647130@arcas>
References: <JIRA.12623301.1355182647130@arcas>
Subject: [jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after
 gc_grace
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625862#comment-13625862 ] 

Jonathan Ellis commented on CASSANDRA-5051:
-------------------------------------------

bq. may be it will help if you add the following line in line 169 (testCleanupDuringRangeMovement)

That does help.  I think the test and the code are both wrong. :)

First, the code is wrong because the range being moved is going from node 2's range to node 3.  The "local" node's range ({{[01 .. 02)}}) is unaffected by the bootstrap here.  Only node 3 should add that range to its "don't throw this away on cleanup" list.  (So, just don't drop the destination part of TM.getPendingRanges and this will be trivial to calculate.)

Second, the test is wrong because (as written) it should only retain keys from {{[01 .. 02]}}.  What we actually need to test is making the local node the one bootstrapping (i.e., having a pending range entry).
                
> Allow automatic cleanup after gc_grace
> --------------------------------------
>
>                 Key: CASSANDRA-5051
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5051
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>              Labels: vnodes
>             Fix For: 2.0
>
>         Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch, 0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch, 5051-v2.txt
>
>
> When using vnodes, after adding a new node you have to run cleanup on all the machines, because you don't know which are affected and chances are it was most if not all of them.  As an alternative to this intensive process, we could allow cleanup during compaction if the data is older than gc_grace (or perhaps some other time period since people tend to use gc_grace hacks to get rid of tombstones.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira