cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5496) Fix SemanticVersion.isSupportedBy patch/minor handling
Date Thu, 18 Apr 2013 16:41:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635325#comment-13635325
] 

Jonathan Ellis commented on CASSANDRA-5496:
-------------------------------------------

+1
                
> Fix SemanticVersion.isSupportedBy patch/minor handling
> ------------------------------------------------------
>
>                 Key: CASSANDRA-5496
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5496
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.4
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.5
>
>         Attachments: 5496.txt
>
>
> Currently we use the following logic:
> {noformat}
> return major == version.major && minor <= version.minor && patch <=
version.patch;
> {noformat}
> This requires both minor and patch vers to be less or equal, which means that, for example,
'3.0.3' is not supported by '3.1.2', because, while 0 <= 1 (minor), 3 > 2 (patch). This
is clearly not the intent since 3.1.2 > 3.0.3.
> CQL3 doc: "Minor version increments occur when new, but backward compatible, functionality
is introduced". Hence '3.0.3' is supposed to be supported by '3.1.0'.
> This doesn't really affect 1.2, but breaks a lot of trunk dtests post CASSANDRA-3919.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message