cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5462) Ant code coverage with unit and dtests
Date Thu, 18 Apr 2013 21:38:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635726#comment-13635726
] 

Dave Brosius edited comment on CASSANDRA-5462 at 4/18/13 9:36 PM:
------------------------------------------------------------------

patch does more than just add coverage tests

1) allows skipping writing license headers with -Dwithout.rat
2) more target skipping with existing -Dwithout.maven

but both of those seem to be fine

There are some tests that are skipped, for coverage, would be better if they were picked up
from a properties file, so that they could be more easily changed. (user.properties would
be nice too).


would be nice to squash the WARN messages on cobertura instrumentation missing line number
tables.

On Java 7, it appears the cobertura instrumentation fails for lack of stack map frame injecting.

Expecting a stackmap frame at branch target 281 in method org.apache.cassandra.gms.Gossiper.<init>()V
at offset 233


                
      was (Author: dbrosius):
    patch does more than just add coverage tests

1) allows skipping writing license headers with -Dwithout.rat
2) more target skipping with existing -Dwithout.maven

but of those seem to be fine

There are some tests that are skipped, for coverage, would be better if they were picked up
from a properties file, so that they could be more easily changed. (user.properties would
be nice too).


would be nice to squash the WARN messages on cobertura instrumentation missing line number
tables.

On Java 7, it appears the cobertura instrumentation fails for lack of stack map frame injecting.

Expecting a stackmap frame at branch target 281 in method org.apache.cassandra.gms.Gossiper.<init>()V
at offset 233


                  
> Ant code coverage with unit and dtests
> --------------------------------------
>
>                 Key: CASSANDRA-5462
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5462
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Ryan McGuire
>            Assignee: Brandon Williams
>         Attachments: trunk.5462.cobertura-reports.patch
>
>
> This is a patch to our build.xml to integrate a cobertura code coverage report across
both the unit tests and the dtests. I've had this working for awhile, but it's rather unwieldy:
it takes over 7 hours for it to run on my i5 based laptop. This is because it runs through
the entire dtest suite twice, once without vnodes turned on, and once with. It does work repeatably
though so although it's a monster, it's probably worth including.
> See http://static.enigmacurry.com/tmp/cobertura-report-4-with-vnodes/ for sample output,
run against trunk today.
> Once applied, you just need to run '*ant codecoverage*'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message