cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5385) IndexHelper.skipBloomFilters won't skip non-SHA filters
Date Wed, 03 Apr 2013 13:41:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620916#comment-13620916
] 

Jason Brown commented on CASSANDRA-5385:
----------------------------------------

Committed to trunk, and ScrubTest and LegacySSTableTest now pass. [~carlyeks], does this need
to be applied to 1.2, as well? Seems like it should, but the ScrubTest and LegacySSTableTest
pass on 1.2 without this.
                
> IndexHelper.skipBloomFilters won't skip non-SHA filters
> -------------------------------------------------------
>
>                 Key: CASSANDRA-5385
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5385
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 2.0
>            Reporter: Carl Yeksigian
>            Assignee: Carl Yeksigian
>             Fix For: 1.2.4, 2.0
>
>         Attachments: 5385.patch, 5385-v2.patch
>
>
> Currently, if the bloom filter is not of SHA type, we do not properly skip the bytes.
We need to read out the number of bytes, as happens in the Murmur deserializer, then skip
that many bytes instead of just skipping the hash size. The version needs to be passed into
the method as well, so that it knows what type of index it is, and does the appropriate skipping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message