cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5062) Support CAS
Date Thu, 11 Apr 2013 09:57:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628800#comment-13628800
] 

Sylvain Lebresne edited comment on CASSANDRA-5062 at 4/11/13 9:56 AM:
----------------------------------------------------------------------

Actually my bad, I should have ran the test before, but there is a few unit test failures.
At least ColumnFamilyStoreTest is failing because it uses ColumnFamily.isEmpty that has been
changed by the patch to include the deletionInfo. I'm fine just updating the test to use getColumnCount()
instead, but it would be nice to do a quick check of all the current uses of ColumnFamily.isEmpty
to make sure this don't break anything else (and we should update the comment of the isEmpty
method).

I also get
{noformat}
    [junit] Testcase: testRowMutationRead(org.apache.cassandra.db.SerializationsTest):	Caused
an ERROR
    [junit] addr is of illegal length
    [junit] java.net.UnknownHostException: addr is of illegal length
    [junit] 	at java.net.InetAddress.getByAddress(InetAddress.java:935)
    [junit] 	at java.net.InetAddress.getByAddress(InetAddress.java:1318)
    [junit] 	at org.apache.cassandra.net.CompactEndpointSerializationHelper.deserialize(CompactEndpointSerializationHelper.java:38)
    [junit] 	at org.apache.cassandra.net.MessageIn.read(MessageIn.java:62)
    [junit] 	at org.apache.cassandra.db.SerializationsTest.testRowMutationRead(SerializationsTest.java:263)
{noformat}
My initial reaction was to say that this is unrelated to this ticket but the test passes on
trunk. Maybe the patch just need to be rebased?
                
      was (Author: slebresne):
    Actually my bad, I should have ran the test before, but there is a few unit test failures.
At least ColumnFamilyStoreTest is failing because it uses ColumnFamily.isEmpty that has been
changed by the patch to include the deletionInfo. I'm fine just updating the test to use getColumnCount()
instead, but it would be nice to do a quick check of all the current uses of ColumnFamily.isEmpty
to make sure this don't break anything else (and we should update the comment of the isEmpty
method).
                  
> Support CAS
> -----------
>
>                 Key: CASSANDRA-5062
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5062
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>            Reporter: Jonathan Ellis
>             Fix For: 2.0
>
>         Attachments: half-baked commit 1.jpg, half-baked commit 2.jpg, half-baked commit
3.jpg
>
>
> "Strong" consistency is not enough to prevent race conditions.  The classic example is
user account creation: we want to ensure usernames are unique, so we only want to signal account
creation success if nobody else has created the account yet.  But naive read-then-write allows
clients to race and both think they have a green light to create.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message