cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
Date Mon, 29 Apr 2013 14:24:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644509#comment-13644509
] 

Jonathan Ellis edited comment on CASSANDRA-5051 at 4/29/13 2:24 PM:
--------------------------------------------------------------------

bq. V6 addressees the test concerns

Why do half a dozen tests need initServer now?

When I rip pendingranges out of getNodeRange, CPTest still passes:

{code}
.   private List<Range<Token>> getNodeRange()
    {
        List<Range<Token>> ranges = new ArrayList<Range<Token>>(StorageService.instance.getLocalRanges(cfs.table.getName()));
        return ranges;
    }
{code}

This may be because it's still hitting the "empty ranges == all ranges" code in isInRanges,
which looks kind of fishy to me -- if we have the pending ranges in getNodeRange, we shouldn't
need this extra piece.
                
      was (Author: jbellis):
    bq. V6 addressees the test concerns

Why do half a dozen tests need initServer now?

When I rip pendingranges out of getNodeRange, CPTest still passes:

{code}
.   private List<Range<Token>> getNodeRange()
    {
        List<Range<Token>> ranges = new ArrayList<Range<Token>>(StorageService.instance.getLocalRanges(cfs.table.getName()));
        return ranges;
    }
{code}

                  
> Allow automatic cleanup after gc_grace
> --------------------------------------
>
>                 Key: CASSANDRA-5051
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5051
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>              Labels: vnodes
>             Fix For: 2.0
>
>         Attachments: 0001-5051-v4.patch, 0001-5051-v6.patch, 0001-5051-with-test-fixes.patch,
0001-CASSANDRA-5051.patch, 0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch,
0004-5051-additional-test-v4.patch, 5051-v2.txt
>
>
> When using vnodes, after adding a new node you have to run cleanup on all the machines,
because you don't know which are affected and chances are it was most if not all of them.
 As an alternative to this intensive process, we could allow cleanup during compaction if
the data is older than gc_grace (or perhaps some other time period since people tend to use
gc_grace hacks to get rid of tombstones.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message