cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
Date Tue, 16 Apr 2013 05:17:16 GMT


Vijay commented on CASSANDRA-5051:

(i.e.: localhost is a Normal token; another node is Bootstrapping)
I think thats exactly what the test does :)

tk0 (Local node owns the whole range before BS) is taking over the whole range but it is still
        // test if node streaming is not dropping the data.
        tmd.addBootstrapToken(new BytesToken(tk0), InetAddress.getByName(""));
        tmd.updateNormalToken(new BytesToken(tk2), FBUtilities.getBroadcastAddress());
        StorageService.calculatePendingRanges(table.getReplicationStrategy(), table.getName());"Range movement scheduled for: {}", tmd.getPendingRanges(table.getName()));
        CompactionManager.instance.submitMaximal(cfs, Integer.MAX_VALUE).get();

At the least I'd add an assert to make sure empty really does imply isBoostrapping.
Will do, Let me know... Thanks!
> Allow automatic cleanup after gc_grace
> --------------------------------------
>                 Key: CASSANDRA-5051
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>              Labels: vnodes
>             Fix For: 2.0
>         Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch,
0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch,
> When using vnodes, after adding a new node you have to run cleanup on all the machines,
because you don't know which are affected and chances are it was most if not all of them.
 As an alternative to this intensive process, we could allow cleanup during compaction if
the data is older than gc_grace (or perhaps some other time period since people tend to use
gc_grace hacks to get rid of tombstones.)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message