cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
Date Mon, 15 Apr 2013 16:34:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631835#comment-13631835
] 

Jonathan Ellis commented on CASSANDRA-5051:
-------------------------------------------

It still looks to me like the test is not checking range calculation for a node that is in
the process of bootstrapping (i.e.: localhost is a Normal token; another node is Bootstrapping).

I think I liked the isInRanges implementation better before the "if it's empty, assume we're
bootstrapping" refactor.  At the least I'd add an assert to make sure empty really does imply
isBoostrapping.
                
> Allow automatic cleanup after gc_grace
> --------------------------------------
>
>                 Key: CASSANDRA-5051
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5051
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>              Labels: vnodes
>             Fix For: 2.0
>
>         Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch,
0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch,
5051-v2.txt
>
>
> When using vnodes, after adding a new node you have to run cleanup on all the machines,
because you don't know which are affected and chances are it was most if not all of them.
 As an alternative to this intensive process, we could allow cleanup during compaction if
the data is older than gc_grace (or perhaps some other time period since people tend to use
gc_grace hacks to get rid of tombstones.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message