cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
Date Mon, 08 Apr 2013 04:05:16 GMT


Jonathan Ellis commented on CASSANDRA-5051:

Did you read the comments on the ticket you linked?

bq. The reason cleanup and compaction are different things is that rows that do not belong
to the current node can be generated by CL.ANY writes as well as "left behind" by token changes...
 We don't have an efficient way to ask "does key exist in hints" (hints are keyed by target).

Hinted handoff no longer works by storing foreign material in the data tables.

I also alluded to another reason in my first comment here:

bq. Throwing away data silently still makes me nervous ... but it's easy enough to set up
a real backup strategy now that I think we're okay.

Incremental backups and PITR also did not exist back in November 2010.
> Allow automatic cleanup after gc_grace
> --------------------------------------
>                 Key: CASSANDRA-5051
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Vijay
>              Labels: vnodes
>             Fix For: 2.0
>         Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch,
0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch,
> When using vnodes, after adding a new node you have to run cleanup on all the machines,
because you don't know which are affected and chances are it was most if not all of them.
 As an alternative to this intensive process, we could allow cleanup during compaction if
the data is older than gc_grace (or perhaps some other time period since people tend to use
gc_grace hacks to get rid of tombstones.)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message