Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09C6EFFA3 for ; Fri, 29 Mar 2013 16:25:17 +0000 (UTC) Received: (qmail 28636 invoked by uid 500); 29 Mar 2013 16:25:16 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 28541 invoked by uid 500); 29 Mar 2013 16:25:16 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 28416 invoked by uid 99); 29 Mar 2013 16:25:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Mar 2013 16:25:16 +0000 Date: Fri, 29 Mar 2013 16:25:16 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617483#comment-13617483 ] Jonathan Ellis commented on CASSANDRA-5403: ------------------------------------------- Patchset pushed to https://github.com/jbellis/cassandra/tree/5403. (To save me rebase pain, it builds on the patches for CASSANDRA-5395, which are not yet committed, but you don't need to re-review those.) > Clean up ColumnFamily, ISortedColumns heirarchy > ----------------------------------------------- > > Key: CASSANDRA-5403 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 > Project: Cassandra > Issue Type: Bug > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > > CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). > This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. > Other things that would be nice to clean up: > # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. > # Many places still use TMBSC where ABSC would be adequate and cheaper > # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira