Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 089B2F92C for ; Mon, 25 Mar 2013 21:33:17 +0000 (UTC) Received: (qmail 27756 invoked by uid 500); 25 Mar 2013 21:33:16 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 27733 invoked by uid 500); 25 Mar 2013 21:33:16 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 27722 invoked by uid 99); 25 Mar 2013 21:33:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Mar 2013 21:33:16 +0000 Date: Mon, 25 Mar 2013 21:33:16 +0000 (UTC) From: "Jason Brown (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5348) Remove row cache until we can replace it with something better MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613172#comment-13613172 ] Jason Brown commented on CASSANDRA-5348: ---------------------------------------- I agree with Sylvain on this. We've spent a lot of time and effort pitching row cacheing, and it might be a bit of a kick in the shins to pull it out on those use who've decided to give it a shot (and are using it successfully). There are a few (few, mind you) reasonable uses of row cache here at NFLX, and those users are happy with it. I'll agree about the education piece, but I think it would be good to have our rewrite story reasonably organized before asking the community to avoid row caches. That way, we can have a smoother transition for users. Unless the effort of working around the current implementation is a complete road block to getting the new hotness up and running, I think we should keep the existing solution around. Making the rewrite a priority for 2.1 gets a +1 from me. > Remove row cache until we can replace it with something better > -------------------------------------------------------------- > > Key: CASSANDRA-5348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5348 > Project: Cassandra > Issue Type: Task > Components: Core > Reporter: Jonathan Ellis > Assignee: Vijay > Fix For: 2.0 > > > The row (partition) cache easily does more harm than good. People expect it to act like a query cache but it is very different than that, especially for the wide partitions that are so common in Cassandra data models. > Making it off-heap by default only helped a little; we still have to deserialize the partition to the heap to query it. > Ultimately we can add a better cache based on the ideas in CASSANDRA-1956 or CASSANDRA-2864, but even if we don't get to that until 2.1, removing the old row cache for 2.0 is a good idea. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira