cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-5395) Compaction doesn't remove index entries as designed
Date Thu, 28 Mar 2013 20:05:18 GMT


Sam Tunnicliffe commented on CASSANDRA-5395:

lgtm, just have 2 trivial queries:

In LCR & PCR, if the purpose of the additional clauses is to omit unnecessary column lookups,
should the column lookup be the last of the &&'d  conditions?

 if (indexer != SecondaryIndexManager.nullUpdater
                    && !column.isMarkedForDelete()
                    && container.getColumn( != column)

Class documentation in IdentityQueryFilter states "Only for use in testing; will read entire
CF into memory." Seeing as its being used in non-test code we should probably amend the docstring

> Compaction doesn't remove index entries as designed
> ---------------------------------------------------
>                 Key: CASSANDRA-5395
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.4
>         Attachments: 5395-2.txt, 5395.txt
> PerColumnIndexUpdater ignores updates where the new value is a tombstone.  It should
still remove the index entry on oldColumn.
> (Note that this will not affect user-visible correctness, since KeysSearcher/CompositeSearcher
will issue deletes against stale index entries, but having more stale entries than we "should"
could affect performance.)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message