cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-4885) Remove or rework per-row bloom filters
Date Thu, 14 Mar 2013 16:20:13 GMT


Jonathan Ellis commented on CASSANDRA-4885:

LGTM in principle.  Details:
- Should bump the Thrift interface minor version
- Don't need to update the avro definition, it's only used for upgrading 1.0 schemas
- Probably cleaner to use an AlwaysPresentFilter rather than special-casing nulls
- Similarly, should deserialize to APF.  This will allow cleaning up some special-casing of
BF in SSTNamesIterator.

- space before open paren of {{if}}, please.
- the BF byte in RIE.serialize would be clearer as a single writeByte(ternary expression)
to make more clear that we always write that byte

> Remove or rework per-row bloom filters
> --------------------------------------
>                 Key: CASSANDRA-4885
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>             Fix For: 2.0
>         Attachments: 0001-CASSANRDA-4885-Remove-per-row-bloom-filter.patch, 0002-CASSANRDA-4885-update-test.patch,
> Per-row bloom filters may be a misfeature.
> On small rows we don't create them.
> On large rows we essentially only do slice queries that can't take advantage of it.
> And on very large rows if we ever did deserialize it, the performance hit of doing so
would outweigh the benefit of skipping the actual read.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message