cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-3919) Dropping a column should do more than just remove the definition
Date Sat, 16 Mar 2013 04:28:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604112#comment-13604112
] 

Aleksey Yeschenko edited comment on CASSANDRA-3919 at 3/16/13 4:27 AM:
-----------------------------------------------------------------------

https://github.com/iamaleksey/cassandra/compare/3919

- ALTER TABLE DROP is limited to CQL3 tables (composite && !compact)
- dropped columns are stored as a map<column, dropped_time>
- the map is a json pseudomap, not a collection. let's convert everything in one go in CASSANDRA-4603
- for compaction, it seems like modifying CFS.removeDeletedStandard() alone is enough

Tested modified compaction manually before implementing extra-filtering in reads, tested reads
manually (+ collection updates that require read-before-write). Everything seems to work.

What's left:
- write dtests for reads
- write unit tests for compaction leaving out dropped columns (can't be a dtest)
- update cqlsh help
- update CQL3 doc

Will do these after the patch is committed, but before resolving the issue in jira.
                
      was (Author: iamaleksey):
    https://github.com/iamaleksey/cassandra/compare/3919

- ALTER TABLE RENAME is limited to CQL3 tables (composite && !compact)
- dropped columns are stored as a map<column, dropped_time>
- the map is a json pseudomap, not a collection. let's convert everything in one go in CASSANDRA-4603
- for compaction, it seems like modifying CFS.removeDeletedStandard() alone is enough

Tested modified compaction manually before implementing extra-filtering in reads, tested reads
manually (+ collection updates that require read-before-write). Everything seems to work.

What's left:
- write dtests for reads
- write unit tests for compaction leaving out dropped columns (can't be a dtest)
- update cqlsh help
- update CQL3 doc

Will do these after the patch is committed, but before resolving the issue in jira.
                  
> Dropping a column should do more than just remove the definition
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-3919
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3919
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Aleksey Yeschenko
>              Labels: compaction, cql
>             Fix For: 1.2.4
>
>
> Dropping a column should:
> - immediately make it unavailable for {{SELECT}}, including {{SELECT *}}
> - eventually (i.e., post-compaction) reclaim the space formerly used by that column

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message