cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject [3/3] git commit: clean up string concatenation in logging
Date Tue, 26 Mar 2013 22:20:29 GMT
clean up string concatenation in logging


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b79b236d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b79b236d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b79b236d

Branch: refs/heads/trunk
Commit: b79b236d0009ed9c4037642d9cc3325d5f56c521
Parents: 29bea2e
Author: Jonathan Ellis <jbellis@apache.org>
Authored: Tue Mar 26 16:49:02 2013 -0500
Committer: Jonathan Ellis <jbellis@apache.org>
Committed: Tue Mar 26 16:49:02 2013 -0500

----------------------------------------------------------------------
 .../org/apache/cassandra/transport/Message.java    |    4 ++--
 .../org/apache/cassandra/transport/Server.java     |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b79b236d/src/java/org/apache/cassandra/transport/Message.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/transport/Message.java b/src/java/org/apache/cassandra/transport/Message.java
index d4d3da6..a6602a0 100644
--- a/src/java/org/apache/cassandra/transport/Message.java
+++ b/src/java/org/apache/cassandra/transport/Message.java
@@ -274,14 +274,14 @@ public abstract class Message
                 ServerConnection connection = (ServerConnection)request.connection();
                 connection.validateNewMessage(request.type);
 
-                logger.debug("Received: " + request);
+                logger.debug("Received: {}", request);
 
                 Response response = request.execute(connection.getQueryState(request.getStreamId()));
                 response.setStreamId(request.getStreamId());
                 response.attach(connection);
                 connection.applyStateTransition(request.type, response.type);
 
-                logger.debug("Responding: " + response);
+                logger.debug("Responding: {}", response);
 
                 ctx.getChannel().write(response);
             }

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b79b236d/src/java/org/apache/cassandra/transport/Server.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/transport/Server.java b/src/java/org/apache/cassandra/transport/Server.java
index 68160c6..bf28b2b 100644
--- a/src/java/org/apache/cassandra/transport/Server.java
+++ b/src/java/org/apache/cassandra/transport/Server.java
@@ -132,7 +132,7 @@ public class Server implements CassandraDaemon.Server
         }
 
         // Bind and start to accept incoming connections.
-        logger.info("Starting listening for CQL clients on " + socket + "...");
+        logger.info("Starting listening for CQL clients on {}...", socket);
         Channel channel = bootstrap.bind(socket);
         connectionTracker.allChannels.add(channel);
     }
@@ -292,7 +292,7 @@ public class Server implements CassandraDaemon.Server
             {
                 // That should not happen, so log an error, but return the
                 // endpoint address since there's a good change this is right
-                logger.error("Problem retrieving RPC address for " + endpoint, e);
+                logger.error("Problem retrieving RPC address for %s", endpoint, e);
                 return endpoint;
             }
         }


Mime
View raw message