Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 9 Jan 2013 19:02:13 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12626804.1357752693436.108094.1357758133780@arcas>
In-Reply-To: <JIRA.12626804.1357752693436@arcas>
References: <JIRA.12626804.1357752693436@arcas>
Subject: [jira] [Commented] (CASSANDRA-5137) Make sure SSTables left over
 from compaction get deleted and logged
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548832#comment-13548832 ] 

Sylvain Lebresne commented on CASSANDRA-5137:
---------------------------------------------

Hum wait, it only works if we have all ancestors though. What if just one ancestor don't get deleted for some reason (or only some of the SSTableDeletingTask have executed before a crash)? It's easy enough to check that we have *all* ancestors, but what if we don't? We're back to square one :(
                
> Make sure SSTables left over from compaction get deleted and logged
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-5137
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5137
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 1.1.9, 1.2.1
>
>         Attachments: 5137-1.1.txt
>
>
> When opening ColumnFamily, cassandra checks SSTable files' ancestors and skips loading already compacted ones. Those files are expected to be deleted, but currently that never happens.
> Also, there is no indication of skipping loading file in the log, so it is confusing especially doing upgradesstables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira