Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 698D7E253 for ; Wed, 9 Jan 2013 18:34:13 +0000 (UTC) Received: (qmail 84296 invoked by uid 500); 9 Jan 2013 18:34:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 84266 invoked by uid 500); 9 Jan 2013 18:34:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 84257 invoked by uid 99); 9 Jan 2013 18:34:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2013 18:34:13 +0000 Date: Wed, 9 Jan 2013 18:34:13 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5137) Make sure SSTables left over from compaction get deleted and logged MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548791#comment-13548791 ] Jonathan Ellis commented on CASSANDRA-5137: ------------------------------------------- You're right, you don't actually need a marker since if compaction completes the next step is to remove the ancestors. I think "if ancestors are still alive, assume compaction didn't finish and delete the descendants" is good enough. > Make sure SSTables left over from compaction get deleted and logged > ------------------------------------------------------------------- > > Key: CASSANDRA-5137 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5137 > Project: Cassandra > Issue Type: Bug > Affects Versions: 1.1.3 > Reporter: Yuki Morishita > Assignee: Yuki Morishita > Priority: Minor > Fix For: 1.1.9, 1.2.1 > > Attachments: 5137-1.1.txt > > > When opening ColumnFamily, cassandra checks SSTable files' ancestors and skips loading already compacted ones. Those files are expected to be deleted, but currently that never happens. > Also, there is no indication of skipping loading file in the log, so it is confusing especially doing upgradesstables. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira