Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1415CEE92 for ; Mon, 14 Jan 2013 19:38:14 +0000 (UTC) Received: (qmail 13997 invoked by uid 500); 14 Jan 2013 19:38:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 13977 invoked by uid 500); 14 Jan 2013 19:38:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 13968 invoked by uid 99); 14 Jan 2013 19:38:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jan 2013 19:38:13 +0000 Date: Mon, 14 Jan 2013 19:38:13 +0000 (UTC) From: "Yuki Morishita (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-4316) Compaction Throttle too bursty with large rows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuki Morishita updated CASSANDRA-4316: -------------------------------------- Attachment: 4316-1.2-v2.txt Slightly updated around RateLimiter creation. > Compaction Throttle too bursty with large rows > ---------------------------------------------- > > Key: CASSANDRA-4316 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4316 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 0.8.0 > Reporter: Wayne Lewis > Assignee: Yuki Morishita > Fix For: 1.2.1 > > Attachments: 4316-1.2.txt, 4316-1.2-v2.txt, 4316-1.2-v2.txt > > > In org.apache.cassandra.db.compaction.CompactionIterable the check for compaction throttling occurs once every 1000 rows. In our workload this is much too large as we have many large rows (16 - 100 MB). > With a 100 MB row, about 100 GB is read (and possibly written) before the compaction throttle sleeps. This causes bursts of essentially unthrottled compaction IO followed by a long sleep which yields inconsistence performance and high error rates during the bursts. > We applied a workaround to check throttle every row which solved our performance and error issues: > line 116 in org.apache.cassandra.db.compaction.CompactionIterable: > if ((row++ % 1000) == 0) > replaced with > if ((row++ % 1) == 0) > I think the better solution is to calculate how often throttle should be checked based on the throttle rate to apply sleeps more consistently. E.g. if 16MB/sec is the limit then check for sleep after every 16MB is read so sleeps are spaced out about every second. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira