cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-5172) Detect (and warn) unintentional use of the cql2 thrift methods when cql3 was the intention
Date Fri, 18 Jan 2013 15:30:12 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne updated CASSANDRA-5172:
----------------------------------------

    Attachment: 5172.txt

In fact I think we can just have set_cql_version complain if a client asks for CQL3. Indeed,
a client that does so is a client that has not been upgraded to use the new thrift CQL3 methods
and such client is guaranteed to not work correctly. So no point in letting him continue thinking
everything is fine.

Patch attached to do that.
                
> Detect (and warn) unintentional use of the cql2 thrift methods when cql3 was the intention

> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5172
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5172
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: 5172.txt
>
>
> In 1.2.0 we've separated the thrift methods for CQL2 and CQL3 (due to CASSANDRA-4734).
In doing so, we've made set_cql_version a silent no-op.
> However it means that the 1.1 way of querying CQL3 now silently end up calling CQL2 in
1.2.0. So I suggest that if someone calls set_cql_version, we record the version set and warn
if (throw an invalid exception) if someone asks for CQL3 but later use the CQL2 methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message