cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5137) Make sure SSTables left over from compaction get deleted and logged
Date Wed, 09 Jan 2013 20:14:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548944#comment-13548944
] 

Jonathan Ellis commented on CASSANDRA-5137:
-------------------------------------------

You're right.  Guess we need a compaction-finished flag after all.

Instead of storing it in sstable metadata, maybe we could store it in system.local the way
we do with truncation information.  Unfortunately 1.1 doesn't support Maps so we'd be doing
two separate implementations for 1.1 and 1.2.

Should we just say that for 1.1 we'll retain all sstables (counter users will get overcounts,
everyone else just gets extra compaction work) and fix it better in 1.2?
                
> Make sure SSTables left over from compaction get deleted and logged
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-5137
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5137
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 1.1.9, 1.2.1
>
>         Attachments: 5137-1.1.txt
>
>
> When opening ColumnFamily, cassandra checks SSTable files' ancestors and skips loading
already compacted ones. Those files are expected to be deleted, but currently that never happens.
> Also, there is no indication of skipping loading file in the log, so it is confusing
especially doing upgradesstables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message