cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3648) Repair should validate checksums before streaming
Date Thu, 31 Jan 2013 18:55:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567938#comment-13567938
] 

Vijay commented on CASSANDRA-3648:
----------------------------------

{quote}
I think they are, via CRAR.decompressChunk(), but just want to confirm.
{quote}
but with a caveat, crc_check_chance controls how much we check.

{quote}
is what should happen when one file fails to stream when there are several (or many) to stream
{quote}
Looks like... We might want to handle this separately for bootstrap vs Repair, for repair
it might be ok to stream the rest but for BS we need to fail it, Separate ticket SGTM.

Thanks for reviewing and will commit it to trunk in few min.


                
> Repair should validate checksums before streaming
> -------------------------------------------------
>
>                 Key: CASSANDRA-3648
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3648
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: 0001-CASSANDRA-3648.patch
>
>
> We have block checksums and sha1 full-file hashes, but currently we do not validate these
before streaming in a repair.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message