Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFB28E63D for ; Fri, 28 Dec 2012 00:00:12 +0000 (UTC) Received: (qmail 49382 invoked by uid 500); 28 Dec 2012 00:00:12 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 49357 invoked by uid 500); 28 Dec 2012 00:00:12 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 49346 invoked by uid 99); 28 Dec 2012 00:00:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Dec 2012 00:00:12 +0000 Date: Fri, 28 Dec 2012 00:00:12 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CASSANDRA-5093) Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Aleksey Yeschenko created CASSANDRA-5093: -------------------------------------------- Summary: Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy Key: CASSANDRA-5093 URL: https://issues.apache.org/jira/browse/CASSANDRA-5093 Project: Cassandra Issue Type: Bug Affects Versions: 1.2.0 rc2 Reporter: Aleksey Yeschenko Assignee: Aleksey Yeschenko Priority: Minor Fix For: 1.2.0 0.1 is supposed to be the default bloom_filter_fp_chance for LeveledCompactionStrategy (and 0.01 for all other strategies). However, CFPropDefs#applyToCFMetadata() sets bloom_filter_fp_chance before setting compaction strategy class, so the default bloom_filter_fp_chance is always 0.01 no matter what the compaction strategy is. The fix is to move cfm#bloomFilterFpChance() call below cfm#compressionParameters(). The attached patch also kills dead default consistency level-related code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira