Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 11 Dec 2012 00:01:23 +0000 (UTC)
From: "Jason Brown (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12618929.1354735679133.14795.1355184083018@arcas>
In-Reply-To: <JIRA.12618929.1354735679133@arcas>
References: <JIRA.12618929.1354735679133@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-5031) Add ssl support to binary
 protocol
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528463#comment-13528463 ] 

Jason Brown edited comment on CASSANDRA-5031 at 12/11/12 12:01 AM:
-------------------------------------------------------------------

OK, fixed the missing cipher_suites, setup the SSLContext in the ctor, and added the netty SSL use to SimpleClient. As for the reconnect bug I mentioned earlier, it was because I held final reference to the SslEngine (shouldn't use it across client sessions).

Also, not sure about this, but I have my IDE (intellij) set up to order imports like the cassandra style guide, so that rearranged things at the top of the submitted classes. Should I avoid doing that for existing classes as that makes the diff noisier? Thanks
                
      was (Author: jasobrown):
    OK, fixed the missing cipher_suites, setup the SSLContext in the ctor, and added the netty SSL use to SimpleClient. As for the reconnect bug I mentioned earlier, it was because I held final reference to the SslEngine (shouldn't use it across client sessions).
                  
> Add ssl support to binary protocol
> ----------------------------------
>
>                 Key: CASSANDRA-5031
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5031
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>             Fix For: 1.2.1
>
>         Attachments: 0001-CASSANDRA-5031-add-ssl-support-to-cql-binary-protoco.patch, 0002-CASSANDRA-5031_round2.patch
>
>
> CASSANDRA-4239 added support in Thrift

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira