Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92366E3E7 for ; Mon, 31 Dec 2012 05:26:15 +0000 (UTC) Received: (qmail 17084 invoked by uid 500); 31 Dec 2012 05:26:14 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 16885 invoked by uid 500); 31 Dec 2012 05:26:14 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 16851 invoked by uid 99); 31 Dec 2012 05:26:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Dec 2012 05:26:13 +0000 Date: Mon, 31 Dec 2012 05:26:12 +0000 (UTC) From: "Vijay (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-3648) Repair should validate checksums before streaming MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-3648: ----------------------------- Attachment: 0001-CASSANDRA-3648.patch Attached patch has DataIntegratyMetadata for Uncompressed SST's, basically while flushing the buffer checksum is calculated and written to a separate CRC file. while streaming for bootstrap or after manual repair, we will check the chunk checksum (If crc file exists) before streaming the data over. Let me know if this is good enough. For RR it is kind of really expensive and we might be better off with compressed Data than checking for checksums. > Repair should validate checksums before streaming > ------------------------------------------------- > > Key: CASSANDRA-3648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3648 > Project: Cassandra > Issue Type: New Feature > Reporter: Jonathan Ellis > Assignee: Vijay > Priority: Minor > Fix For: 2.0 > > Attachments: 0001-CASSANDRA-3648.patch > > > We have block checksums and sha1 full-file hashes, but currently we do not validate these before streaming in a repair. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira