cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5053) not possible to change crc_check_chance
Date Wed, 19 Dec 2012 05:09:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535645#comment-13535645
] 

Aleksey Yeschenko commented on CASSANDRA-5053:
----------------------------------------------

LGTM and works.

Attaching v2 with minor tweaks:
- renamed CFS#crcCheckChance() to CFS#setCrcCheckChance()
- renamed CompressionParameters.globalOptions to CompressionParameters.GLOBAL_OPTIONS and
made it an ImmutableSet instead of a HashSet
- CompressionParameters#parseCrcCheckChance() throws CE now - just logging the error and returning
default is not enough (Cassandra will save invalid crc_check_chance and you'll get that NumberFormatException
every time you start Cassandra)
- added crc_check_chance range validation to parseCrcCheckChance, otherwise we get the same
issue as above with valid doubles, but out of range values
- very minor formatting tweaks for consistency

Will commit tomorrow.
                
> not possible to change crc_check_chance
> ---------------------------------------
>
>                 Key: CASSANDRA-5053
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5053
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 1.1.9
>
>         Attachments: 0001-CASSANDRA-5053-make-it-possible-to-change-crc_check_.patch,
0001-fix-CASSANDRA-5053-not-possible-to-change-crc_check_.patch, 5053-v2.txt
>
>
> It is not possible to change crc_check_chance using a schema modification after CASSANDRA-4266
> This patch fixes that and moves the setting out into a configuration parameter instead,
you dont want to upgrade/scrub/.. all your sstables to change the crc_check_chance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message