cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5043) Small CollationController refactoring and CFS.getRawCachedRow(DecoratedKey) fix.
Date Tue, 11 Dec 2012 08:07:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528786#comment-13528786
] 

Sylvain Lebresne commented on CASSANDRA-5043:
---------------------------------------------

I'm not arguing performance, I'm saying the attached patch is buggy and will throw assertion
errors.
                
> Small CollationController refactoring and CFS.getRawCachedRow(DecoratedKey) fix.
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5043
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5043
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: CASSANDRA-5043.patch
>
>
> CollactionController can construct a factory on init based on mutableColumns parameter.
ArrayBackedSortedColumns proven to be better for counters as well as normal columns (row size
from 5 to 75 columns). CFS.getRawCachedRow would copy key byte array each time it contracts
a RowCacheKey so we want to avoid that where possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message