cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5031) Add ssl support to binary protocol
Date Tue, 11 Dec 2012 15:17:23 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529042#comment-13529042
] 

Sylvain Lebresne commented on CASSANDRA-5031:
---------------------------------------------

bq. It's used by SimpleClient.SecurePipelineFactory's constructor.

Oh. My surprise was that it wasn't use on the server side too. But looking further, the answer
seems to be that the server don't need the trustStore part. Can't we however just add a boolean
'isServer' to createSSLContext and skip the trustStore stuffs in that case? The rest is the
same and this keyStore business feels out of place in the Server class.

The rest lgtm.
                
> Add ssl support to binary protocol
> ----------------------------------
>
>                 Key: CASSANDRA-5031
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5031
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>             Fix For: 1.2.1
>
>         Attachments: 0001-CASSANDRA-5031-add-ssl-support-to-cql-binary-protoco.patch,
0002-CASSANDRA-5031_round2.patch, 0003-CASSANDRA-5031-round3.patch
>
>
> CASSANDRA-4239 added support in Thrift

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message