cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-5031) Add ssl support to binary protocol
Date Tue, 11 Dec 2012 14:59:21 GMT


Jason Brown updated CASSANDRA-5031:

    Attachment: 0003-CASSANDRA-5031-round3.patch

bq. Why don't we reuse the SSLFactory.createSSLContext method?

It's used by SimpleClient.SecurePipelineFactory's constructor.

bq. not sure I understand this SslStateHandler

Looking at this code fresh, I think I got a little off-track when I ran into the reconnect
bug (which I mentioned above).

Reading the netty source, I see now that calling handshake() explicitly is, in fact, unessecary
as SslHandler.channelConnected() will do that if issueHandshake is already set to true (which
we are already doing).

I, too, was unhappy with the pipeline duplication, but if we did need to inject a channel,
copying and putting a big note seemed better than trying to dance around the ordering with
putBefore(), putAfter(), and so on. 

Either way, we don't need the extra SslStateHandler (client and server sides), and it's removed
in the attached patch. 
> Add ssl support to binary protocol
> ----------------------------------
>                 Key: CASSANDRA-5031
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>             Fix For: 1.2.1
>         Attachments: 0001-CASSANDRA-5031-add-ssl-support-to-cql-binary-protoco.patch,
0002-CASSANDRA-5031_round2.patch, 0003-CASSANDRA-5031-round3.patch
> CASSANDRA-4239 added support in Thrift

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message