Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sat, 17 Nov 2012 13:03:12 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <873247862.127377.1353157393037.JavaMail.jiratomcat@arcas>
In-Reply-To: <5127739.41100.1350116223089.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CASSANDRA-4803) CFRR wide row iterators
 improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CASSANDRA-4803?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13499405#comment-13499405 ]=20

Jonathan Ellis commented on CASSANDRA-4803:
-------------------------------------------

0006: Can you split out the bug fix and rebase?  Refactoring is fine but le=
t's keep it separate from bug fixes.

0007: I'm unclear what this is useful for, anyone running a 1.1 recent enou=
gh to have this patch, would also have describe_splits_ex, no?
               =20
> CFRR wide row iterators improvements
> ------------------------------------
>
>                 Key: CASSANDRA-4803
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4803
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Hadoop
>    Affects Versions: 1.1.0
>            Reporter: Piotr Ko=C5=82aczkowski
>            Assignee: Piotr Ko=C5=82aczkowski
>             Fix For: 1.1.7
>
>         Attachments: 0004-Better-token-range-wrap-around-handling-in-CFIF=
-CFRR.patch, 0006-Code-cleanup-refactoring-in-CFRR.-Fixed-bug-with-mis.patc=
h, 0007-Fallback-to-describe_splits-in-case-describe_splits_.patch
>
>
> {code}
>  public float getProgress()
>     {
>         // TODO this is totally broken for wide rows
>         // the progress is likely to be reported slightly off the actual =
but close enough
>         float progress =3D ((float) iter.rowsRead() / totalRowCount);
>         return progress > 1.0F ? 1.0F : progress;
>     }
> {code}
> The problem is iter.rowsRead() does not return the number of rows read fr=
om the wide row iterator, but returns number of *columns* (every row is cou=
nted multiple times).=20

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira