Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 18 Nov 2012 03:42:12 +0000 (UTC)
From: "Dave Brosius (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <2102167556.128563.1353210132797.JavaMail.jiratomcat@arcas>
In-Reply-To: <1720118038.57220.1351794912177.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CASSANDRA-4893) Don't throw internal exceptions
 over JMX
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499597#comment-13499597 ] 

Dave Brosius commented on CASSANDRA-4893:
-----------------------------------------

doesn't doing

throw new IllegalArgumentException(e);

still exhibit the problem of needing the underlying exception class of 'e' in the classpath of the caller?

why not just catch the exception in the MBean itself, and throw an alternative there, so as not to soften the exception handling in the main codebase?
                
> Don't throw internal exceptions over JMX
> ----------------------------------------
>
>                 Key: CASSANDRA-4893
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4893
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.6, 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Assignee: Yuki Morishita
>             Fix For: 1.2.1
>
>         Attachments: 0001-remove-cassandra-specific-exceptions-from-JMX-interf.patch
>
>
> Similarly to how we don't return internal objects over JMX we shouldn't throw internal exceptions over jmx as well.
> The one example I encountered was throwing ConfigurationException for the move() command. We should check the rest of our jmx as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira