Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E3F3CD8BC for ; Wed, 14 Nov 2012 14:56:12 +0000 (UTC) Received: (qmail 59898 invoked by uid 500); 14 Nov 2012 14:56:12 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 59810 invoked by uid 500); 14 Nov 2012 14:56:12 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 59787 invoked by uid 99); 14 Nov 2012 14:56:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Nov 2012 14:56:12 +0000 Date: Wed, 14 Nov 2012 14:56:12 +0000 (UTC) From: "Sylvain Lebresne (JIRA)" To: commits@cassandra.apache.org Message-ID: <20157748.114006.1352904972430.JavaMail.jiratomcat@arcas> In-Reply-To: <1520792955.95550.1352524632165.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (CASSANDRA-4942) Pool [Compressed]RandomAccessReader on the partitioned read path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497140#comment-13497140 ] Sylvain Lebresne commented on CASSANDRA-4942: --------------------------------------------- BufferedSegmentFile still don't pass the itself to the created RAR (and while I agree that this won't matter to a lot of people since mmap use is more widespread, I don't think there is any reason not to recycle (we'll still save the buffer allocation of RAR if we do)). But with that fix, lgtm, +1. > Pool [Compressed]RandomAccessReader on the partitioned read path > ---------------------------------------------------------------- > > Key: CASSANDRA-4942 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4942 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Priority: Minor > Fix For: 1.2.1 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira