Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 1 Nov 2012 10:45:13 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <1630439187.55391.1351766713454.JavaMail.jiratomcat@arcas>
In-Reply-To: <2061748335.53759.1351728312205.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CASSANDRA-4889) Code cleanup against JDK 1.6
 codestyle guide
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488599#comment-13488599 ] 

Sylvain Lebresne commented on CASSANDRA-4889:
---------------------------------------------

bq. What about adding missing @Override?

Depends of the definition of missing. http://wiki.apache.org/cassandra/CodeStyle explicitly said: "Avoid redundant @Override annotations when implementing abstract or interface methods". But as long as it's missing following that definition, then sure, why not.
                
> Code cleanup against JDK 1.6 codestyle guide
> --------------------------------------------
>
>                 Key: CASSANDRA-4889
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4889
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Radim Kolar
>            Assignee: Radim Kolar
>            Priority: Minor
>              Labels: codestyle
>         Attachments: cass-cleanup1.txt
>
>
> Code cleanup against jdk1.6 ruleset on lowest settings.
> problems fixed:
> extra ;
> unused imports
> incorrect if (condition is always true or always false)
> using static variable in non static way
> always true asserts

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira