cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-4942) Pool [Compressed]RandomAccessReader on the partitioned read path
Date Wed, 14 Nov 2012 16:26:13 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-4942.
---------------------------------------

    Resolution: Fixed

Fixed + committed.

Also fixed a tricky little problem with recyling a deallocated reader:

{code}
.       if (owner == null || buffer == null)
        {
            // The buffer == null check is so that if the pool owner has deallocated us, calling
close()
            // will re-call deallocate rather than recycling a deallocated object.
            // I'd be more comfortable if deallocate didn't have to handle being idempotent
like that,
            // but RandomAccessFile.close will call AbstractInterruptibleChannel.close which
will
            // re-call RAF.close -- in this case, [C]RAR.close since we are overriding that.
            deallocate();
        }
        else
        {
            owner.recycle(this);
        }
{code}
                
> Pool [Compressed]RandomAccessReader on the partitioned read path
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-4942
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4942
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message