cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-5002) UUIGen should never use another host IP for its node part
Date Thu, 29 Nov 2012 12:32:58 GMT
Sylvain Lebresne created CASSANDRA-5002:
-------------------------------------------

             Summary: UUIGen should never use another host IP for its node part
                 Key: CASSANDRA-5002
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5002
             Project: Cassandra
          Issue Type: Bug
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
            Priority: Minor
             Fix For: 1.2.0


UUIDGen allows to specify the inet address that we use to generate the node part of the created
UUID. This is wrong however. More precisely, the node part is what make sure UUID generated
on two different hosts are different, because we can't guarantee that the timestamp and clock
parts will be different. In other words, generating on a host a UUID with the node part of
another host is dangerous is clearly contrary to the spec.

And as it turns out, making sure we always use the local address means that the full lsb part
of the UUID becomes constant (as it should) and we can remove the nodeCache from UUIDGen and
simplify/speedup UUID generation, which is all the more reason to fix it.

I note that we were almost always using the local address to generate UUID anyway. The only
place where we weren't is in Stream{In/Out}Session, and there is virtually no chance that
this has ever broke anything (but we should still fix it).


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message