Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DB6CD15C for ; Wed, 3 Oct 2012 10:40:09 +0000 (UTC) Received: (qmail 65196 invoked by uid 500); 3 Oct 2012 10:40:08 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 65151 invoked by uid 500); 3 Oct 2012 10:40:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 65129 invoked by uid 99); 3 Oct 2012 10:40:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Oct 2012 10:40:07 +0000 Date: Wed, 3 Oct 2012 21:40:07 +1100 (NCT) From: "Sam Tunnicliffe (JIRA)" To: commits@cassandra.apache.org Message-ID: <1686403827.158458.1349260807621.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (CASSANDRA-4752) Drop keyspace causes schema disagreement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Sam Tunnicliffe created CASSANDRA-4752: ------------------------------------------ Summary: Drop keyspace causes schema disagreement Key: CASSANDRA-4752 URL: https://issues.apache.org/jira/browse/CASSANDRA-4752 Project: Cassandra Issue Type: Bug Affects Versions: 1.1.6 Reporter: Sam Tunnicliffe The fix for CASSANDRA-4698 introduced a bug whereby when drop keyspace is issued a schema disagreement immediately occurs. This seems to be because the {code} ColumnFamily cf = ColumnFamily.create(modification.getValue().metadata()); {code} in {{RowMutation.deserializeFixingTimestamps}} does not preserve deletion info for the cf in the modification. In most cases, this doesn't cause a problem, but for a drop keyspace modification, there are no columns in the cf, so the deletion info is effectively lost leading to an incorrect digest being created and ultimately a schema disagreement. Replacing the {{create}} with {{cloneMeShallow}} does preserve the deletion info and avoids the schema disagreement issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira