Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 18 Oct 2012 20:12:03 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <1656562354.65543.1350591123701.JavaMail.jiratomcat@arcas>
In-Reply-To: <2111215737.26594.1349967304460.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CASSANDRA-4792) Digest mismatch doesn't wait
 for writes as intended
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CASSANDRA-4792?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13479316#comment-13479316 ]=20

Jonathan Ellis commented on CASSANDRA-4792:
-------------------------------------------

That, and "it was possible for a quorum read to return an old value, even a=
fter a quorum read had returned a newer value [but the newer value had not =
yet been sent to the other replicas]."
               =20
> Digest mismatch doesn't wait for writes as intended
> ---------------------------------------------------
>
>                 Key: CASSANDRA-4792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4792
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.1.6, 1.2.0 beta 2
>
>         Attachments: 4792.txt
>
>
> As reported by Niklas Ekstr=C3=B6m on the dev list:
> I=E2=80=99m looking in the file StorageProxy.java (Cassandra 1.1.5), and =
line 766 seems odd to me.
> FBUtilities.waitOnFutures() is called with the repairResults from the Row=
RepairResolver resolver.
> The problem though is that repairResults is only assigned when the object=
 is created at line 737 in StorageProxy.java, and there it is assigned to C=
ollections.emptyList(), and in the resolve() method in RowRepairResolver, w=
hich is indirectly called from line 771 in StorageProxy.java, that is, afte=
r the call to FBUtilities.waitOnFutures().
> So the effect is that line 766 in StorageProxy.java is essentially a no-o=
p.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira