Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E6DCD5B7 for ; Mon, 8 Oct 2012 23:42:04 +0000 (UTC) Received: (qmail 99246 invoked by uid 500); 8 Oct 2012 23:42:03 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 99213 invoked by uid 500); 8 Oct 2012 23:42:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99204 invoked by uid 99); 8 Oct 2012 23:42:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2012 23:42:03 +0000 Date: Mon, 8 Oct 2012 23:42:03 +0000 (UTC) From: "Karl Mueller (JIRA)" To: commits@cassandra.apache.org Message-ID: <1383147547.11551.1349739723621.JavaMail.jiratomcat@arcas> In-Reply-To: <1390919647.71862.1342647095050.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (CASSANDRA-4446) nodetool drain sometimes doesn't mark commitlog fully flushed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471960#comment-13471960 ] Karl Mueller commented on CASSANDRA-4446: ----------------------------------------- Also seeing this in an upgrade from 1.0.xx to 1.1.15: INFO 16:29:17,486 completed pre-loading (3 keys) key cache. INFO 16:29:17,495 Replaying /data2/commit-cassandra/CommitLog-1349727956484.log INFO 16:29:17,503 Replaying /data2/commit-cassandra/CommitLog-1349727956484.log INFO 16:29:18,495 GC for ParNew: 3506 ms for 4 collections, 1963062320 used; max is 17095983104 INFO 16:29:18,498 Finished reading /data2/commit-cassandra/CommitLog-1349727956484.log INFO 16:29:18,499 Log replay complete, 0 replayed mutations This is a standard upgrade process which includes a drain > nodetool drain sometimes doesn't mark commitlog fully flushed > ------------------------------------------------------------- > > Key: CASSANDRA-4446 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4446 > Project: Cassandra > Issue Type: Bug > Affects Versions: 1.0.10 > Environment: ubuntu 10.04 64bit > Linux HOSTNAME 2.6.32-345-ec2 #48-Ubuntu SMP Wed May 2 19:29:55 UTC 2012 x86_64 GNU/Linux > sun JVM > cassandra 1.0.10 installed from apache deb > Reporter: Robert Coli > Attachments: cassandra.1.0.10.replaying.log.after.exception.during.drain.txt > > > I recently wiped a customer's QA cluster. I drained each node and verified that they were drained. When I restarted the nodes, I saw the commitlog replay create a memtable and then flush it. I have attached a sanitized log snippet from a representative node at the time. > It appears to show the following : > 1) Drain begins > 2) Drain triggers flush > 3) Flush triggers compaction > 4) StorageService logs DRAINED message > 5) compaction thread excepts > 6) on restart, same CF creates a memtable > 7) and then flushes it [1] > The columnfamily involved in the replay in 7) is the CF for which the compaction thread excepted in 5). This seems to suggest a timing issue whereby the exception in 5) prevents the flush in 3) from marking all the segments flushed, causing them to replay after restart. > In case it might be relevant, I did an online change of compaction strategy from Leveled to SizeTiered during the uptime period preceding this drain. > [1] Isn't commitlog replay not supposed to automatically trigger a flush in modern cassandra? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira